[cxx-interop] Do not try to import std::tzdb
#73086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In libstdc++13 on Ubuntu 23.10 the type `std::tzdb` is non-copyable but does not explicitly delete its copy constructor. It instead triggers template instantiation errors when trying to use the copy constructor. This is problematic for Swift, since we try to instantiate copy constructors for most C++ types we import. This disables the import of `std::tzdb` to unblock nightly toolchains for Ubuntu 23.10 until we come up with a better solution. rdar://126486849 / #73037
|
@swift-ci please smoke test |
egorzhdan
added a commit
that referenced
this pull request
Aug 23, 2024
This type is non-copyable, but its implementation in libstdc++13 does not explicitly declare a deleted copy constructor. After rebranch, we should start using API Notes to annotate the type as a non-copyable type in Swift. For now, this change disables import of this type. See #73086 rdar://134432426
egorzhdan
added a commit
that referenced
this pull request
Aug 23, 2024
This type is non-copyable, but its implementation in libstdc++13 does not explicitly declare a deleted copy constructor. After rebranch, we should start using API Notes to annotate the type as a non-copyable type in Swift. For now, this change disables import of this type. See #73086 rdar://134432426 (cherry picked from commit 386c8eb)
andrurogerz
pushed a commit
to andrurogerz/swift
that referenced
this pull request
Sep 3, 2024
This type is non-copyable, but its implementation in libstdc++13 does not explicitly declare a deleted copy constructor. After rebranch, we should start using API Notes to annotate the type as a non-copyable type in Swift. For now, this change disables import of this type. See swiftlang#73086 rdar://134432426
andrurogerz
pushed a commit
to andrurogerz/swift
that referenced
this pull request
Sep 3, 2024
This type is non-copyable, but its implementation in libstdc++13 does not explicitly declare a deleted copy constructor. After rebranch, we should start using API Notes to annotate the type as a non-copyable type in Swift. For now, this change disables import of this type. See swiftlang#73086 rdar://134432426
etcwilde
pushed a commit
to etcwilde/swift
that referenced
this pull request
Sep 5, 2024
This type is non-copyable, but its implementation in libstdc++13 does not explicitly declare a deleted copy constructor. After rebranch, we should start using API Notes to annotate the type as a non-copyable type in Swift. For now, this change disables import of this type. See swiftlang#73086 rdar://134432426 (cherry picked from commit 386c8eb)
etcwilde
pushed a commit
to etcwilde/swift
that referenced
this pull request
Sep 5, 2024
This type is non-copyable, but its implementation in libstdc++13 does not explicitly declare a deleted copy constructor. After rebranch, we should start using API Notes to annotate the type as a non-copyable type in Swift. For now, this change disables import of this type. See swiftlang#73086 rdar://134432426 (cherry picked from commit 386c8eb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libstdc++13 on Ubuntu 23.10 the type
std::tzdbis non-copyable but does not explicitly delete its copy constructor. It instead triggers template instantiation errors when trying to use the copy constructor. This is problematic for Swift, since we try to instantiate copy constructors for most C++ types we import.This disables the import of
std::tzdbto unblock nightly toolchains for Ubuntu 23.10 until we come up with a better solution.rdar://126486849 / #73037