[ScanDependencies] Do not count optional dependencies when not needed #73087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
…no interface" This reverts commit 90a1586.
cachemeifyoucan
force-pushed
the
eng/PR-testable-import-deps-optional
branch
from
abddb06 to
70762fa
Compare
|
@swift-ci please smoke test |
|
@artemcm this tries to fix the binary testable module in a different direction to match better with the current behavior. |
cachemeifyoucan
force-pushed
the
eng/PR-testable-import-deps-optional
branch
from
70762fa to
eb5981b
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
If a testable module is loaded from a non-testable import, ignore its optional dependencies because the consumer should not use them. This matches the behavior of the implicit build or the behavior how forwarding module is created.
cachemeifyoucan
force-pushed
the
eng/PR-testable-import-deps-optional
branch
from
eb5981b to
77fefe9
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a testable module is loaded from a non-testable import, ignore its optional dependencies because the consumer should not use them. This matches the behavior of the implicit build or the behavior how forwarding module is created.