[6.0][CSBindings] Delay inference through OptionalObject if "object" is l-value capable #73105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value capable Inference cannot be allowed in cases where both sides are type variables and optional type is l-value capable because it results in binding "optional" to an optional type and later discovering a contextual type that is l-value optional i.e. if "optional type" is resolved by selecting subscript overload. (cherry picked from commit 7654afd)
(cherry picked from commit 1038493)
xedin
changed the title
|
@swift-ci please test |
hborla
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #73083
Inference cannot be allowed in cases where both sides are type
variables and optional type is l-value capable because it results
in binding "optional" to an optional type and later discovering
a contextual type that is l-value optional i.e. if "optional type"
is resolved by selecting subscript overload.
Scope: expressions with optional chaining.
Main Branch PRs: [CSBindings] Delay inference through OptionalObject if "object" is l-value capable #73083
Risk: Low
Resolves: rdar://117871338
Reviewed By: @hborla
Testing: Added test-cases to the test suite.