Skip to content

[6.0][ASTGen] Update for SPI in swift-syntax #73115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Apr 18, 2024

Cherry-pick #71513 into release/6.0

(Copied from swiftlang/swift-syntax#2608)

  • Explanation: SwiftCompilerPluginMessageHandling is only intended to be used from internal modules like SwiftCompilerPlugin, or ASTGen and swift-plugin-server in swift repository. Make all the public symbols SPI so other third party modules don't accidentally use it.
  • Scope: Macro plugins
  • Risk: Low, Nobody should depends on SwiftCompilerPluginMessageHandling APIs
  • Testing: Passes current test suite
  • Issue: N/A
  • Reviewer: Alex Hoppen (@ahoppen)

All symbols in `SwiftCompilerPluginMessageHandling` are now SPI.

(cherry picked from commit ae3a169)
@rintaro rintaro requested a review from a team as a code owner April 18, 2024 19:22
@rintaro
Copy link
Member Author

rintaro commented Apr 18, 2024

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Apr 18, 2024

@swift-ci Please test

@rintaro rintaro enabled auto-merge April 18, 2024 21:58
@rintaro rintaro merged commit d68a494 into swiftlang:release/6.0 Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants