Respect the module ABI name when mangling for the debugger #73119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mangled name produced for the debugger should match the one emitted in reflection metadata, otherwise LLDB will not be able to lookup types when the module is compiled with the -module-abi-name flag. rdar://125848324 (cherry picked from commit 01bd68e)
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
adrian-prantl
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mangled name produced for the debugger should match the one emitted in reflection metadata, otherwise LLDB will not be able to lookup types when the module is compiled with the -module-abi-name flag.
rdar://125848324
(cherry picked from commit 01bd68e)
Explanation: LLDB needs the mangled names of types stored in debug info to match those in reflection metadata, otherwise it won't be able to look up those types.
Scope: Small.
Issue: rdar://125848324
Original PRs: https://github.com/apple/swift/pull/72335 & https://github.com/apple/swift/pull/72624
Risk: Low, this only debugging and when swift-programs are compiled with
-module-abi-name.Testing: Added DebugInfo/module_abi_name.swift
Reviewer: @adrian-prantl