[6.0] Serialization: Protect against most errors in contexts for calls to AnyObject variables
#73139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-error resilient call sites like this: DeclContext *DC = MF.getDeclContext(contextID); Can be replaced with this error tolerant alternative: DeclContext *DC; UNWRAP(MF.getDeclContextChecked(contextID), DC);
|
@swift-ci Please test |
xymus
changed the title
AnyObject variablesAnyObject variables
nkcsgexi
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recover from deserialization errors in accesses to the context in all
deserialize*functions. Calls on aAnyObjecttyped variable triggers access to all loaded class members directly. The context of these members can be non-public or broken by a context change. Make sure most context accesses can recover from this and bubble up any error instead of crashing.UNWRAPmacro and protect against most errors in contexts #73113