[cmake] Check correctly for different flags. Do check twice -Wall #73144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
check_cxx_compiler_flag caches its results for the same variable, since all the flags were using the same variable, only the first check was done, and the rest of the flags were just using the result of the first flag. Make each of the check_cxx_compiler_flag use a different variable (by interpolating the flag name) and reorder the list of compiler flags to check. -Wall was added twice, and in the case of MSVC, the equivalent was added last. It doesn't really seem to affect a lot of things.
drodriguez
force-pushed
the
cmake-support-flags
branch
from
b53da41 to
892aa71
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_cxx_compiler_flag caches its results for the same variable, since all the flags were using the same variable, only the first check was done, and the rest of the flags were just using the result of the first flag.
Make each of the check_cxx_compiler_flag use a different variable (by interpolating the flag name) and reorder the list of compiler flags to check. -Wall was added twice, and in the case of MSVC, the equivalent was added last.
It doesn't really seem to affect a lot of things.