[LifetimeCompletion] Don't destroy alloc_boxes. #73155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than repeating the same expression that already defines it.
nate-chandler
force-pushed
the
lifetime-completion/20240419/1
branch
2 times, most recently
from
22c0cd8 to
aac6fae
Compare
When deallocating a partially allocated class in the trapping branch of an unfailable cast, cast back down to the subclass which is being partially deallocated before emitting the dealloc partial ref instruction.
A destroy_value of an alloc_box unconditionally destroys the value within the box. On unreachable paths, such memory may not be initialized, so it cannot be destroyed unconditionally. Moreover, destroying values stored in memory is outside the purview of OSSA lifetime completion.
nate-chandler
force-pushed
the
lifetime-completion/20240419/1
branch
from
aac6fae to
6a01bf4
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
destroy_valueof analloc_boxunconditionally destroys the value within the box. On unreachable paths, such memory may not be initialized, so it cannot be destroyed unconditionally. Moreover, destroying values stored in memory is outside the purview of OSSA lifetime completion.