[SILGen] Create thunks for non-throwing -> indirect error result conversions #73162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersions
When a non-throwing function is passed to a function that expects a
throwing function with an indirect error result, we need to create a
thunk because the indirect error result pointer is passed as an extra
trailing parameter. Extra trailing parameters except for `swifterror`
and `swiftself` are not allowed on some platforms like WebAssembly, so
they need to be called as exactly the same function signature.
```swift
func passThrough<X>(_ c: () throws(X) -> Void) throws(X) {
try c()
}
func neverThrow() {}
passThrough(neverThrow)
```
|
@swift-ci test |
|
@swift-ci test WebAssembly |
kateinoigakukun
added
SILGen
MaxDesiatov
added
the
bug
DougGregor
approved these changes
Apr 22, 2024
|
Tracked by rdar://128028703 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a non-throwing function is passed to a function that expects a throwing function with an indirect error result, we need to create a thunk because the indirect error result pointer is passed as an extra trailing parameter. Extra trailing parameters except for
swifterrorandswiftselfare not allowed on some platforms like WebAssembly, so they need to be called as exactly the same function signature.This patch repairs WebAssembly CI failure. It has been failing since the recent typed-throws introduction in
Optional.map.