Skip to content

Sema: Local duplicate of the note about which import limits access-level #73183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Apr 22, 2024

Access-level on imports limit where decls from the target module can be referenced. This is reported by the typical error and a note on the import. When using an IDE and editing a large file, the note on the import is easy to miss. Address this by duplicating the information on the error line as well so it's never out of the IDE's viewport.

rdar://119438201

Access-level on imports limit where decls from the target module can
be referenced. This is reported by the typical error about and a note
on the import. However, when using an IDE and editing a large file,
the note on the import is easy to miss. Address this by duplicating
the information on the error line as well so it's never out of the
current viewport.

rdar://119438201
@xymus xymus requested a review from tshortli April 22, 2024 19:09
@xymus
Copy link
Contributor Author

xymus commented Apr 22, 2024

@swift-ci Please smoke test

@xymus xymus merged commit 8785cf5 into swiftlang:main Apr 23, 2024
@xymus xymus deleted the access-level-import-more-notes branch April 23, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant