[region-isolation] When RegionIsolation is enabled, delay the preconcurrency import not used diagnostic to the SIL pipeline. #73202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teach SILFunction how to use the field to get the SourceFile associated with the SILFunction.
…urrency import not used diagnostic to the SIL pipeline. The reason why I am doing this is that I am going to be adding support for preconcurrency imports to TransferNonSendable. That implies that we can have preconcurrency import suppression in the SIL pipeline and thus that emitting the diagnostic in Sema is too early. To do this, I introduced a new module pass called DiagnoseUnnecessaryPreconcurrencyImports that runs after the SILFunction pass TransferNonSendable. The reason why I use a module pass is to ensure that TransferNonSendable has run on all functions before we attempt to emit these diagnostics. Then in that pass, we iterate over all of the modules functions and construct a uniqued array of SourceFiles for these functions. Then we iterate over the uniqued SourceFiles and use the already constructed Sema machinery to emit the diagnostic using the source files. rdar://126928265
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why I am doing this is that I am going to be adding support for
preconcurrency imports to TransferNonSendable. That implies that we can have
preconcurrency import suppression in the SIL pipeline and thus that emitting the
diagnostic in Sema is too early.
To do this, I introduced a new module pass called
DiagnoseUnnecessaryPreconcurrencyImports that runs after the SILFunction pass
TransferNonSendable. The reason why I use a module pass is to ensure that
TransferNonSendable has run on all functions before we attempt to emit these
diagnostics. Then in that pass, we iterate over all of the modules functions and
construct a uniqued array of SourceFiles for these functions. Then we iterate
over the uniqued SourceFiles and use the already constructed Sema machinery to
emit the diagnostic using the source files.
rdar://126928265