[region-isolation] Suppress non-Sendable region isolation errors appropriately when the type is imported by using @preconcurrency import. #73212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
|
@swift-ci smoke test |
…opriately when the type is imported by using @preconcurrency import. This translates the rules for @preconcurrency import from SE-0337 into the region isolation world. Specifically if a module is compiled without strict concurrency checking and imported with @preconcurrency: 1. All types from that module that are implicitly non-Sendable have diagnostics suppressed in swift 5 and swift 6. 2. All types from that module that are explicitly non-Sendable emit warnings in both swift 5 and swift 6. rdar://126804052
|
Had to turn off availability checking. |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[region-isolation] Suppress non-Sendable region isolation errors appropriately when the type is imported by using @preconcurrency import.
This translates the rules for @preconcurrency import from SE-0337 into the region isolation world. Specifically if a module is compiled without strict concurrency checking and imported with @preconcurrency:
All types from that module that are implicitly non-Sendable have diagnostics suppressed in swift 5 and swift 6.
All types from that module that are explicitly non-Sendable emit warnings in both swift 5 and swift 6.
rdar://126804052
I still need to handle the
@MainActorremoval cases.