[ScanDependency] Allow continue searching for testable module #73227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
When swift dependency scanner first finds a binary module for a testable import, verify if the module is built for enable-testing or not. If not, keeps searching in case there is a second testable binary module in the search path. Previously, the first binary module will always be accepted by scanner and rely on the importer to provide a good diagnostics. Now the scanner will emit a warning before continue searching, so user understands why the binary in the search path is not taken.
cachemeifyoucan
force-pushed
the
eng/PR-testable-fallback
branch
from
492ea31 to
10b3048
Compare
cachemeifyoucan
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
xymus
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When swift dependency scanner first finds a binary module for a testable import, verify if the module is built for enable-testing or not. If not, keeps searching in case there is a second testable binary module in the search path.
Previously, the first binary module will always be accepted by scanner and rely on the importer to provide a good diagnostics. Now the scanner will emit a warning before continue searching, so user understands why the binary in the search path is not taken.