Skip to content

[BitwiseCopyable] Promote to feature. #73235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 4, 2024

Conversation

nate-chandler
Copy link
Contributor

@nate-chandler nate-chandler commented Apr 24, 2024

SE-0426 was accepted.

The ability to suppress conformance to BitwiseCopyable was part of the
accepted SE-428.
@nate-chandler nate-chandler force-pushed the bitwise-copyable/enable branch from 6392928 to d45c90c Compare April 24, 2024 22:53
The unconstrained overloads of loadUnaligned and storeBytes were
deprecated in SE-0426.
@nate-chandler nate-chandler force-pushed the bitwise-copyable/enable branch from b146ade to b12def9 Compare April 25, 2024 18:44
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler
Copy link
Contributor Author

@swift-ci please apple silicon benchmark

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler nate-chandler marked this pull request as ready for review May 4, 2024 00:51
@nate-chandler nate-chandler requested a review from atrick May 4, 2024 00:52
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@@ -179,6 +179,7 @@ LANGUAGE_FEATURE(BuiltinAddressOfRawLayout, 0, "Builtin.addressOfRawLayout")
LANGUAGE_FEATURE(MoveOnlyPartialConsumption, 429, "Partial consumption of noncopyable values")
/// Enable bitwise-copyable feature.
LANGUAGE_FEATURE(BitwiseCopyable, 426, "BitwiseCopyable protocol")
SUPPRESSIBLE_LANGUAGE_FEATURE(ConformanceSuppression, 426, "Suppressible inferred conformances")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ConformanceSuppression considered part of 426 or 428?

Copy link
Contributor Author

@nate-chandler nate-chandler May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahoppen ahoppen removed their request for review May 4, 2024 16:13
@nate-chandler nate-chandler merged commit bcd08c0 into swiftlang:main May 4, 2024
@nate-chandler nate-chandler deleted the bitwise-copyable/enable branch May 4, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants