Skip to content

[LifetimeCompletion] Complete coro token lifetimes with end_borrow. #73274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nate-chandler
Copy link
Contributor

Allow end_borrow uses of such values and update inlining to handle them. Regard such values as BorrowedValues; completion then falls out.

Forwards to the member function of the same name on
MultipleValueInstructionResult.
The token is a guaranteed value introduced by the begin_apply and
consumed by its end_apply, abort_apply, and end_borrow users.
@nate-chandler nate-chandler requested a review from kavon as a code owner April 26, 2024 00:06
@nate-chandler nate-chandler requested review from atrick and meg-gupta and removed request for kavon April 26, 2024 00:07
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@nate-chandler nate-chandler merged commit 80e1ae3 into swiftlang:main Apr 26, 2024
@nate-chandler nate-chandler deleted the lifetime-completion/20240425/1 branch April 26, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants