Skip to content

[Runtime] Avoid dlsym of objc_isUniquelyReferenced. #73285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Apr 26, 2024

We attempted to use the declaration if it exists, and fall back to dlsym. This didn't actually work and we always call dlsym. Include the right header (when available) and add a weak check to the direct call.

rdar://127116080

We attempted to use the declaration if it exists, and fall back to dlsym. This didn't actually work and we always call dlsym. Include the right header (when available) and add a weak check to the direct call.

rdar://127116080
@mikeash mikeash requested a review from al45tair as a code owner April 26, 2024 15:45
@mikeash
Copy link
Contributor Author

mikeash commented Apr 26, 2024

@swift-ci please test

Copy link
Contributor

@Catfish-Man Catfish-Man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Somehow had paged out the WEAK_CHECK/WEAK_USE stuff, but it's very straightforward now that I looked it up

@mikeash mikeash enabled auto-merge April 26, 2024 17:57
@mikeash mikeash merged commit c9996e3 into swiftlang:main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants