Fix dev-scripts/split-cmdline: quote ';' arguments #73287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When printing an argument that contains ';', add back the quotes that are normally stripped. I regularly waste half a day building Swift only to find that I built the wrong thing because everything after the semicolon is dropped from the build script when it contains arguments like this: '--llvm-install-components=libclang;libclang-headers' Ideally, split-cmdline would just preserve the original quotes. But this quick fix solves the problem in the cases that I care about.
|
@swift-ci test |
|
@swift-ci smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing an argument that contains ';', add back the quotes that are normally stripped.
I regularly waste half a day building Swift only to find that I built the wrong thing because everything after the semicolon is dropped from the build script when it contains arguments like this:
'--llvm-install-components=libclang;libclang-headers'
Ideally, split-cmdline would just preserve the original quotes. But this quick fix solves the problem in the cases that I care about.