stdlib: Fix more typed throws and non-copyable generics condfails #73306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two categories of problem for older compilers that consume the stdlib `.swiftinterface`: - The `case .some(borrowing x)` syntax isn't accepted; use `_borrowing` - Various functions that addopted `~Copyable` generic constraints conflict with the `@usableFromInline` ABI stubs that were left in to preserve compatibility when the functions are printed with `~Copyable` constraints stripped. The stubs need to have different names to get out of the way. Resolves rdar://127132742
|
@swift-ci please test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two categories of problem for older compilers that consume the stdlib
.swiftinterface:case .some(borrowing x)syntax isn't accepted; use_borrowing~Copyablegeneric constraints conflict with the@usableFromInlineABI stubs that were left in to preserve compatibility when the functions are printed with~Copyableconstraints stripped. The stubs need to have different names to get out of the way.Fixes fallout from #73045.
Resolves rdar://127132742