[Parse] Fix crash in conditional compilation parsing #7331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
jtbandes
force-pushed
the
stability-should-be-unconditional
branch
from
3265417 to
db2b7c2
Compare
|
@swift-ci please smoke test |
|
This is technically a source breaking change. 😢 #if true && true &&
print("ok")
#endifdoes compile, and prints "ok". (since it's no-assert build) |
|
That's true. It might be pretty easy to keep the old behavior in Swift 3 mode. I would be interested to hear what @DougGregor thinks about whether it's important... |
|
I don't consider that source-break important. The likelihood of this affecting real-world code is small, and that code is obviously invalid. PR LGTM, thanks! |
jtbandes
force-pushed
the
stability-should-be-unconditional
branch
from
db2b7c2 to
5c4185a
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up some diagnostics and fixes a crasher reported by @practicalswift in https://twitter.com/practicalswift/status/829066902869786625.
Also, this is now disallowed (it seemed to be allowed only unintentionally):