Emit line table entries for closure setup instructions. #73326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
requested review from
eeckstein,
kastiglione,
augusto2112,
felipepiovezan and
Snowy1803
adrian-prantl
force-pushed
the
127095833
branch
from
7142607 to
435636a
Compare
|
@swift-ci test |
Currently the Swift compiler makes these instructions with SILLocations marked
as autgenerated. While this allows for somewhat smoother stepping in some cases,
it can also make some debugging tasks harder due to missing source location
information, for example, when attributing memory allocations.
This patch makes these locations available again, based on that a debug info
consumer could consider filtering them out by recognizing that a source location
is on the opening `{` of a closure, but inside the scope of the function the
closure is defined in.
rdar://127095833
adrian-prantl
force-pushed
the
127095833
branch
from
435636a to
82a26a5
Compare
adrian-prantl
changed the title
|
@swift-ci test |
Snowy1803
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Swift compiler makes these instructions with SILLocations marked as autgenerated. While this allows for somewhat smoother stepping in some cases, it can also make some debugging tasks harder due to missing source location information, for example, when attributing memory allocations.
This patch makes these locations available again, based on that a debug info consumer could consider filtering them out by recognizing that a source location is on the opening
{of a closure, but inside the scope of the function the closure is defined in.rdar://127095833