Skip to content

[transferring] Make transferring conditionally suppressible and validate that we do suppress transferring in swift interface files. #73355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2024
Merged

[transferring] Make transferring conditionally suppressible and validate that we do suppress transferring in swift interface files. #73355

merged 1 commit into from
May 1, 2024

Conversation

gottesmm
Copy link
Contributor

Importantly I added tests that validated this behavior.

rdar://126780823

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm enabled auto-merge April 30, 2024 21:31
tshortli
tshortli approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@tshortli tshortli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tshortli
Copy link
Contributor

If a lot of existing APIs are going to adopt transferring, we may want to invert this by always printing a suppressed alternative so that we don't accidentally make APIs disappear by adopting transferring and forgetting @_allowFeatureSuppression. Is there a motivation for only conditionally printing suppressed alternatives? The @_disallowFeatureSuppression attribute exists for edge cases where we need to hide the alternatives.

@gottesmm gottesmm disabled auto-merge April 30, 2024 22:00
@gottesmm
Copy link
Contributor Author

For anyone listening in, @tshortli and I touched base offline and agreed that it made sense to not conditionally suppress and just suppress.

@gottesmm
[transferring] Make transferring suppressible and validate that we do…
dc25857 
… suppress transferring in swift interface files.

Importantly I added tests that validated this behavior.

rdar://126780823
@gottesmm gottesmm force-pushed the pr-acaafaf08d92c2605381e4381508530cf0c3a1ba branch from 5d6c86a to dc25857 Compare April 30, 2024 23:40
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm enabled auto-merge April 30, 2024 23:41
@gottesmm gottesmm merged commit 85cabf5 into swiftlang:main May 1, 2024
@gottesmm gottesmm deleted the pr-acaafaf08d92c2605381e4381508530cf0c3a1ba branch May 1, 2024 04:00
@gottesmm gottesmm mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshortli tshortli tshortli approved these changes

@ktoso ktoso Awaiting requested review from ktoso ktoso is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gottesmm @tshortli