[LifetimeCompletion] Require boundary to be specified. #73386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to search for since editors will see it as a single name.
This lambda has to do with availability or the lack thereof but unreachable instructions are of interest in this context so using the wrong name confuses things unnecessarily.
Match the declaration order.
Don't default to one boundary or another based on whether the value being completed is lexical.
The new boundary allows for invalid OSSA where values are not consumed on paths leading to blocks that exit the function normally. In such cases, the value is allowed to continue leaking as before.
Use the new AvailabilityWithLeaks boundary.
nate-chandler
force-pushed
the
lifetime-completion/20240501/2
branch
from
ea41ac8 to
284262d
Compare
|
@swift-ci please test |
nate-chandler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't default to one boundary or another based on whether the value being completed is lexical. For SILGenCleanup, use a new boundary: "availability with leaks". The new boundary lets values that are already leaked on paths that exit the function normally to remain leaked (unless they are only leaked on some paths that exit the function through a given normal exit block in which case they will be destroyed on the availability boundary of the value).