[SourceKit] Don't use SourceEntitityWalker for placeholder expansion #73394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Placeholder expansion should be a syntactic operation, but `SourceEntityWalker` can invoke type checking operations, which causes unexpected bahaviors including crashes. rdar://121360941`
|
@swift-ci Please smoke test |
hamishknight
approved these changes
May 2, 2024
Comment on lines
1743
to
+1745
| if (E->getStartLoc() == TargetLoc) | ||
| return false; // found what we needed to find, stop walking. | ||
| return true; | ||
| return Action::Stop(); // found what we needed to find, stop walking. | ||
| return Action::Continue(E); |
There was a problem hiding this comment.
Could use Action::StopIf here if you want
There was a problem hiding this comment.
Oh, thanks for the tip! but let me merge this as is for now 🙏
| PreWalkAction walkToDeclPre(Decl *D) override { | ||
| if (auto *ICD = dyn_cast<IfConfigDecl>(D)) { | ||
| for (auto Clause : ICD->getClauses()) { | ||
| // Active clase elements are visited normally. |
There was a problem hiding this comment.
Suggested change
| // Active clase elements are visited normally. | |
| // Active clause elements are visited normally. |
ahoppen
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placeholder expansion should be a syntactic operation, but
SourceEntityWalkercan invoke type checking operations, which causes unexpected bahaviors including crashes.rdar://121360941`