[DebugInfo] Fix PhiExpansion losing debug info #73404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When replacing a struct with its field, it now emits a debug_value with a fragment, instead of dropping the debug_value.
|
@swift-ci please test |
adrian-prantl
approved these changes
May 4, 2024
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replacing a struct with its field, it now emits a debug_value with a fragment, instead of dropping the debug_value.
PhiExpansion was the 6th SIL pass losing most debug variables in the standard library (6936 -> 0 variables lost).
It only salvages the fragment kept as the new phi node — it might be worth to "move" the debug_value to the predecessors to keep the whole value, but I don't think it would have a real impact.