[SIL] Hollow out Builtin.copy and deprecate _copy. #73422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
rdar127502242
branch
from
6a0e263 to
91e88db
Compare
atrick
approved these changes
May 3, 2024
|
It looks like the main concern is source compatibility with the removal of the always-emit-into-client |
lorentey
approved these changes
May 3, 2024
tshortli
approved these changes
May 3, 2024
lorentey
reviewed
May 3, 2024
| @@ -265,3 +265,12 @@ extension String { | |||
| } | |||
| } | |||
| #endif | |||
|
|
|||
| @available(swift, deprecated: 6, message: "Use the copy operator") | |||
There was a problem hiding this comment.
It would be better to rather deprecate this in all language modes, not just in Swift 6+:
Suggested change
| @available(swift, deprecated: 6, message: "Use the copy operator") | |
| @available(*, deprecated, message: "Use the copy operator") |
nate-chandler
force-pushed
the
rdar127502242
branch
from
a281002 to
c5d2cac
Compare
|
The copy operator has been implemented and doesn't use it. Remove `Builtin.copy` and `_copy` as much as currently possible. Source compatibility requires that `_copy` remain in the stdlib. It is deprecated here and just uses the copy operator. Handling old swiftinterfaces requires that `Builtin.copy` be defined. Redefine it here as a passthrough--SILGen machinery will produce the necessary copy_addr. rdar://127502242
nate-chandler
force-pushed
the
rdar127502242
branch
from
c5d2cac to
06921cf
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
nate-chandler
changed the title
nate-chandler
requested review from
a team,
kavon,
hborla,
slavapestov,
xedin and
eeckstein
as code owners
|
Source compat failures match failures in baseline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy operator has been implemented and doesn't use it. Remove
Builtin.copyand_copyas much as currently possible.Source compatibility requires that
_copyremain in the stdlib. It is deprecated here and just uses the copy operator.Handling old swiftinterfaces requires that
Builtin.copybe defined. Redefine it here as a passthrough--SILGen machinery will produce the necessary copy_addr.rdar://127502242