[DebugInfo] Always emit unsubstituted generic types with size 0 #73430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsubstituted generic types shouldn't have a size, precisely because the generic parameters aren't substituted in. Always emit them with a size 0. (cherry picked from commit 128d452)
|
@swift-ci test |
adrian-prantl
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsubstituted generic types shouldn't have a size, precisely because the generic parameters aren't substituted in. Always emit them with a size 0.
(cherry picked from commit 128d452)
Explanation: When emitting debug information for unsubstituted generic types, the size of the type can't be known, since the generics haven't been substituted in yet. This patch fixes that by emitting them with a size of 0.
Scope: Affects debug info generation of generic types when compiling with
-gdwarf-types, or for embedded Swift.Risk: Low. Only affects debug info generation for generics in some situations.
Reviewer: @adrian-prantl
Main branch PR: #72445