Skip to content

[AST] Remove Builtin.copy. #73443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

nate-chandler
Copy link
Contributor

A vestigial remnant of it was left behind after 06921cf in order to avoid a reverse condfail when building old swiftinterfaces that define

func _copy<T>(_ value: T) -> T {
  #if $BuiltinCopy
    Builtin.copy(value)
  #else
    value
  #endif
}

If the language feature is removed, though, such interfaces should again be buildable because the branch where the language feature isn't defined should be expanded.

rdar://127516085

A vestigial remnant of it was left behind after
06921cf in order to avoid a reverse
condfail when building old swiftinterfaces that define

```swift
func _copy<T>(_ value: T) -> T {
  #if $BuiltinCopy
    Builtin.copy(value)
  #else
    value
  #endif
}
```

If the language feature is removed, though, such interfaces should again
be buildable because the branch where the language feature isn't defined
should be expanded.

rdar://127516085
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler requested a review from tshortli May 4, 2024 20:14
@nate-chandler nate-chandler marked this pull request as ready for review May 5, 2024 16:10
@nate-chandler nate-chandler requested review from a team, hborla, slavapestov and xedin as code owners May 5, 2024 16:10
@nate-chandler nate-chandler merged commit bf6058b into swiftlang:main May 6, 2024
@nate-chandler nate-chandler deleted the rdar127516085 branch May 6, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant