[6.0][region-isolation] Tweaking diagnostics a little bit to match terminology we are using else where. #73447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test windows platform |
…g -> sending. rdar://127580781 (cherry picked from commit 699692b)
…d of just saying 'callee'. I also wordsmithed the error message to use the term 'risk' instead of less negative terms. (cherry picked from commit 0b76110)
…f it is not disconnected. Just another diagnostic tweak. (cherry picked from commit a933c14)
…of could. (cherry picked from commit f02172a)
(cherry picked from commit 266432c)
(cherry picked from commit 58fd432) Conflicts: test/sil-opt/swift-version.sil
|
This successfully passed all tests, but I by mistake included an unnecessary commit. |
gottesmm
force-pushed
the
release-6.0-rdar127580781
branch
from
d7820b2 to
b7401e8
Compare
|
@swift-ci test |
rdar://127580781 (cherry picked from commit e4db879)
|
I was asked to tweak the diagnostics a little bit further. |
|
@swift-ci test |
|
@swift-ci test linux platform |
1 similar comment
|
@swift-ci test linux platform |
rdar://127580781 (cherry picked from commit f64f252)
|
@swift-ci test |
hborla
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This PR contains small changes to the actual diagnostic text that we emit for region isolation. I am making the change to match evolved ways of talking about these errors.
Original PRs:
Risk: Low. Just tweaking diagnostics.
Testing: Updated /all/ of the region isolation tests to reflect the diagnostic change.
Reviewer: N/A