Sema: Treat the implicit RawRepresentable conformance for enums as Synthesized again.
#7345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ynthesized` again. This reverts part of swiftlang#4038 which made the compiler consider it to be an `Explicit` conformance, breaking source code that was accepted in Swift 3.0 which declared a raw type as well as explicit conformance to `RawRepresentable` (reported as rdar://problem/30386658). While I'm here, a couple of spot fixes: - Ensure an enum's raw value exprs are type-checked before checking conformances of any of its extensions, since the RawRepresentable conformance derivation will blow up if the raw value exprs haven't been checked. Fixes an order dependency issue if `extension Foo: RawRepresentable {}` gets checked before `enum Foo: Int { ... }`. - Don't display the custom `enum_declares_rawrep_with_raw_type` diagnostic if the source location for the enum's inheritance clause is invalid, so that we don't emit a dislocated diagnostic.
|
@swift-ci Please test |
|
@DougGregor How's this look for 3.1? Anything else you would suggest to help narrow the amount of additional checking enum extensions force? |
|
Build failed |
DougGregor
approved these changes
Feb 9, 2017
|
@jimingham Is the |
|
@swift-ci Please test Linux |
|
Build failed |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts part of #4038 which made the compiler consider it to be an
Explicitconformance, breaking source code that was accepted in Swift 3.0 which declared a raw type as well as explicit conformance toRawRepresentable(reported as rdar://problem/30386658). While I'm here, a couple of spot fixes:extension Foo: RawRepresentable {}gets checked beforeenum Foo: Int { ... }.enum_declares_rawrep_with_raw_typediagnostic if the source location for the enum's inheritance clause is invalid, so that we don't emit a dislocated diagnostic.