[6.0] Fix incorrect BitwiseCopyable conformance lookups #73462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
approved these changes
May 6, 2024
slavapestov
force-pushed
the
bitwise-copyable-lookup-conformance-irgen-6.0
branch
2 times, most recently
from
602463f to
b2d6a56
Compare
Fixes rdar://126637139, rdar://126779977.
slavapestov
force-pushed
the
bitwise-copyable-lookup-conformance-irgen-6.0
branch
from
b2d6a56 to
31c761f
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.0 cherry-pick of #73457
Description: IRGen would conclude that certain types were BitwiseCopyable even when they weren't, causing memory leaks because the destroy value operation was not emitted.
Scope of the issue: we would leak all values whose type was a resilient struct or enum with a conditional conformance to BitwiseCopyable, or any tuple type that contains a pack expansion type.
Origination: Recent regression that didn't ship from d1bd039.
Reviewed by: @hborla
Tested: Various new tests added.
Radar: rdar://126637139, rdar://126779977