Skip to content

Add support to the compiler for musl and the LINUX_STATIC SDK. #73485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2024
Merged

Add support to the compiler for musl and the LINUX_STATIC SDK. #73485

merged 3 commits into from
May 8, 2024

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented May 7, 2024

This is really just about setting appropriate defaults (such as making sure that the static Linux triple causes us to use lld).

rdar://123506306

al45tair added 3 commits May 7, 2024 20:31
@al45tair
[Runtime] Fix generation of .lnk files for static linking.
4799767 
Use the new `SWIFT_SDK_<sdk>_STATIC_LINKING_SUPPORTED` and
`_STATIC_ONLY` flags instead of hardcoding support for Linux
and WASI.

Also, use the `_LIB_SUBDIR` variable rather than lowercasing
the SDK.

rdar://123504757
@al45tair
Add support to the compiler for musl and the LINUX_STATIC SDK.
1b8d41a 
This is really just about setting appropriate defaults (such as
making sure that the static Linux triple causes us to use lld).

rdar://123506306
@al45tair
[ClangImporter] Don't put built-in headers in system modules for musl.
43bda98 
We only need this for WASI and Glibc.

rdar://123506306
@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.0 labels May 7, 2024
@al45tair al45tair requested a review from a team as a code owner May 7, 2024 19:56
@al45tair
Copy link
Contributor Author

al45tair commented May 7, 2024

@swift-ci Please test

@al45tair
Copy link
Contributor Author

al45tair commented May 7, 2024

Explanation: We need to make sure the compiler picks the correct linker and build settings.
Original PR: #71844
Risk: Low. This changeset is additive and really only affects the static SDK.
Reviewed by: @MaxDesiatov
Resolves: rdar://123506306
Tests: There are no tests in the repository for the static Linux SDK (because it isn't built by the Swift repo itself). We will be building out CI for it, at which point we will have tests for this. There are already tests for Linux and WASI, which are the two things that might be affected by these changes.

@al45tair al45tair merged commit 0b671d5 into swiftlang:release/6.0 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@al45tair @tbkka