Relax @retroactive check to allow same-package declarations #73512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
harlanhaskins
added
the
swift evolution pending discussion
tshortli
approved these changes
May 8, 2024
harlanhaskins
force-pushed
the
hhaskins/retro-activity
branch
from
da96eed to
9d3c63a
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
cc: @elsh for taking a look. |
elsh
approved these changes
May 9, 2024
harlanhaskins
force-pushed
the
hhaskins/retro-activity
branch
from
d7c76f4 to
b206819
Compare
|
Ha -- the test needs updating for access control on imports |
…lic retroactive extensions
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test |
harlanhaskins
pushed a commit
that referenced
this pull request
Jul 9, 2024
…75079) * Relax @retroactive check to allow same-package declarations * Add package decls to the test too * Fix tests * Import test libraries publicly so I can use their conformances in public retroactive extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes the @retroactive check to allow conformances as long as either the type or the protocol is declared in the same package as the extension.
Resolves rdar://127738893