[BitwiseCopyable] Avoid a condfail. #73516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
rdar127755503
branch
from
11d03df to
4199d9f
Compare
tshortli
approved these changes
May 8, 2024
nate-chandler
force-pushed
the
rdar127755503
branch
2 times, most recently
from
91593a5 to
4927939
Compare
Rather than immediately outright banning the old protocol, just make it be a deprecated typealias for the real one.
The standard library defines
```
protocol BitwiseCopyable {}
typealias _BitwiseCopyable = BitwiseCopyable
```
For current compilers, `BitwiseCopyable` is a "known protocol".
For older compilers, it is not; instead `_BitwiseCopyable` is. So
print the following into the swiftinterface for those older compilers:
```
protocol _BitwiseCopyable {}
typealias BitwiseCopyable = _BitwiseCopyable
```
rdar://127755503
nate-chandler
force-pushed
the
rdar127755503
branch
from
4927939 to
2671652
Compare
|
@swift-ci please test |
nate-chandler
requested review from
hborla,
slavapestov,
xedin and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard library defines
For current compilers,
BitwiseCopyableis a "known protocol".For older compilers, it is not; instead
_BitwiseCopyableis. So print the following into the swiftinterface for those older compilers:rdar://127755503