[6.0][Macros] Ensure reaping executable plugin process #73548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
compnerd
approved these changes
May 9, 2024
rdar://126489446 (cherry picked from commit 0a0e665)
rintaro
force-pushed
the
6.0-macros-plugin-waitpid-rdar126489446
branch
from
ec077c0 to
e535249
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #73547 into release/6.0
waitpidfor plugins. This hasn't been an issue because usually the lifetime of plugin process is the same as the host process (i.e.swift-frontendorSourceKitService). But when the plugin somehow decided to crash, it went zombie and the compiler respawn another process to recover. This patch ensures reaping the existed plugin process, so the system can clear the processllvm::sys::Waitdoeswaitfor the child process, or terminate it. ThisLoadedExecutablePlugin::PluginProcess::~PluginProcess()is called when the plugin process crashed, or the host process exits.