Skip to content

[debug] Print strings using their description in the debugger #73550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2024

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented May 9, 2024

When using po in the debugger on a string, it currently prints out the debugDescription which should be used when using p. Check for string and just return the description.

Resolves: rdar://109902298

@Azoy Azoy requested a review from kastiglione May 9, 2024 21:38
@Azoy Azoy requested a review from a team as a code owner May 9, 2024 21:38
@Azoy
Copy link
Contributor Author

Azoy commented May 9, 2024

@swift-ci please smoke test

Copy link
Contributor

@kastiglione kastiglione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Azoy
Copy link
Contributor Author

Azoy commented May 15, 2024

@swift-ci please smoke test

@Azoy
Copy link
Contributor Author

Azoy commented May 15, 2024

@swift-ci please smoke test

Copy link
Contributor

@kastiglione kastiglione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@Azoy Azoy merged commit db9232f into swiftlang:main May 16, 2024
3 checks passed
@Azoy Azoy deleted the string-debugger-changes branch May 16, 2024 18:40
kastiglione added a commit to swiftlang/llvm-project that referenced this pull request Aug 15, 2024
Test `po` of a multiline string and verify that newlines are not escaped.

See swiftlang/swift#73550
kastiglione added a commit to swiftlang/llvm-project that referenced this pull request Aug 19, 2024
Test `po` of a multiline string and verify that newlines are not escaped.

See swiftlang/swift#73550

(cherry-picked from commit e02c6a8)
kastiglione added a commit to swiftlang/llvm-project that referenced this pull request Aug 19, 2024
Test `po` of a multiline string and verify that newlines are not escaped.

See swiftlang/swift#73550

(cherry-picked from commit e02c6a8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants