-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[6.0][Concurrency] Remove last usages of @_unsafeInheritExecutor #73569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0][Concurrency] Remove last usages of @_unsafeInheritExecutor #73569
Conversation
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Hmmm, there's one problem we need to discuss and solve about isolation of the closure still.
Blocking on rdar://125078448 |
Unblocked and cleaned up 🎉 |
b492538
to
b44afcf
Compare
@swift-ci please test |
Meh, depends on #74563 so this will fail this run. |
@swift-ci please test |
move tests to existing actor_withCancellationHandler.swift file
b44afcf
to
9b8b5eb
Compare
@swift-ci please test |
This should have been a compile time error but seems it wasn't caught. Remove the * from the backDeployed as this is not something which makes sense and would break adopter projects.
@swift-ci please test |
@swift-ci please test macOS |
Description: We still had a few stray uses of @_unsafeInheritExecutor which we are intending to stop using entirely. The uses were in task cancellation handler (which I noticed), and withTaskGroup*.
Scope/Impact: Use the official way of inheriting isolation, rather than the fragile unofficial attribute. Impact on users is more correct inheritance of context, making APIs usable in actors in Swift 6 mode.
Risk: Low, Verified ABI method remain and only adds #isolation new API
Testing: CI testing, added tests to verify behavior of task cancellation handler inside actor
Reviewed by: @hborla
Original PR: #73568
Radar: rdar://127874129
--
depends on #74563