[embedded] Explicitly install the embedded concurrency .a libraries with +x permissions #73599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith +x permissions
kubamracek
requested review from
MaxDesiatov,
phausler,
rokhinip,
rauhul,
zoecarver and
eeckstein
|
@swift-ci please test |
|
@swift-ci Please Build Toolchain macOS Platform |
|
Toolchains looks good (embedded libswift_Concurrency.a is actually present now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The embedded concurrency .a libraries are produced and pass some basic tests, but they are missing from downloadable toolchains on swift.org. It seems like that static libraries need to be installed with +x file permissions to make it into the final toolchain, and it's something that is handled for normal libraries in
add_swift_target_library, but since we're usingadd_swift_target_library_singlewe need to do that explicitly.