Skip to content

[WIP][Distributed] Avoid finishNormalConformance for SILGen manually created #73612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WIP][Distributed] Avoid finishNormalConformance for SILGen manually created #73612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lib/Serialization/Deserialization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8335,8 +8335,23 @@ Type ModuleFile::loadTypeEraserType(const TypeEraserAttr *TRA,
void ModuleFile::finishNormalConformance(NormalProtocolConformance *conformance,
uint64_t contextData) {
using namespace decls_block;

PrettyStackTraceModuleFile traceModule(*this);

if (conformance->isConformanceOfProtocol()) {
auto *dc = conformance->getDeclContext();
auto &C = dc->getASTContext();

// Currently this we should only be skipping only be happening for the
// "DistributedActor as Actor" SILGen generated conformance.
// See `isConformanceOfProtocol` for details, if adding more such
// conformances, consider changing the way we structure their construction.
assert(conformance->getProtocol()->getInterfaceType()->isEqual(
C.getProtocol(KnownProtocolKind::Actor)->getInterfaceType()) &&
"Only expected to 'skip' finishNormalConformance for manually "
"created DistributedActor-as-Actor conformance.");
return;
}

PrettyStackTraceConformance trace("finishing conformance for",
conformance);
++NumNormalProtocolConformancesCompleted;
Expand Down