[6.0] Fix initialization of imported ObjC block types. #73620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a SIL ownership verification error when importing structs like:
typedef bool (^boolBlock)(void);
struct objc_bool_block {
__unsafe_unretained boolBlock block;
};
Fixes rdar://126142109 (Found an operand with a value that is not compatible
with the operand's operand ownership kind map)
(cherry picked from commit c112e03)
|
@swift-ci test |
tbkka
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a SIL ownership verification error when importing structs like:
typedef bool (^boolBlock)(void);
struct objc_bool_block {
__unsafe_unretained boolBlock block;
};
Fixes rdar://126142109 (Found an operand with a value that is not compatible with the operand's operand ownership kind map)
(cherry picked from commit c112e03)
--- CCC ---
Explanation: This fixes a SIL ownership verification error when importing ObjC blocks by making Builtin.zeroInitializer produce an owned SIL value.
Scope: The bug produces invalid SIL, but is unlikely to affect release builds.
Radar/SR Issue: rdar://126142109 (Found an operand with a value that is not compatible with the operand's operand ownership kind map)
main PR: #73577
Risk: Makes it valid in SIL to destroy a zero-initialized value. If that actualy happens, it would be a runtime crash.
Testing: Unit test added.
Reviewer: Egor Zhdan