IRGen: Large types reg2mem - Fix visitUncheckedTrivialBitCastInst #73626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unchecked_trivial_bit_cast can go from a bigger type to a smaller type. Therefore we must allocate stack storage for the operand type rather than the result type. Otherwise, we can end up storing bigger values into smaller storage -- not good. rdar://128086028
|
@swift-ci test |
|
@swift-ci test |
It imports the enum as a signed int rather than an unsigned int like on darwin
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unchecked_trivial_bit_cast can go from a bigger type to a smaller type. Therefore we must allocate stack storage for the operand type rather than the result type. Otherwise, we can end up storing bigger values into smaller storage -- not good.
rdar://128086028