[CodeCompletion] Remove warning for 'async in non-concurrency context' #73628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
ahoppen
approved these changes
May 14, 2024
Comment on lines
-402
to
-404
| if (IsAsync && !canCurrDeclContextHandleAsync) { | ||
| return ContextualNotRecommendedReason::InvalidAsyncContext; | ||
| } |
There was a problem hiding this comment.
Unless I’m missing something, we can remove IsAsync from ContextFreeCodeCompletionResult now.
hamishknight
approved these changes
May 15, 2024
This warnings don't give much benefits for developers. Code completion
UI tends to show them unusable. But usually, developers can modify the
context to accept async calls, e.g. by wrapping it with `Task { }`
rdar://126737530
Same for 'async in non-concurrency' context
rintaro
force-pushed
the
completion-async-not-async-rdar126737530
branch
from
6e9eb59 to
79a7410
Compare
|
@swift-ci Please smoke test |
ahoppen
reviewed
May 16, 2024
| kind, associatedKind, opKind, roles, isSystem, isAsync, | ||
| hasAsyncAlternative, string, moduleName, briefDocComment, | ||
| kind, associatedKind, opKind, roles, isSystem, | ||
| hasAsyncAlternative, string, moduleName, briefDocComment, |
| @@ -236,7 +236,6 @@ static bool readCachedModule(llvm::MemoryBuffer *in, | |||
| auto diagSeverity = | |||
| static_cast<CodeCompletionDiagnosticSeverity>(*cursor++); | |||
| auto isSystem = static_cast<bool>(*cursor++); | |||
| auto isAsync = static_cast<bool>(*cursor++); | |||
There was a problem hiding this comment.
Did you increment the completion cache version number?
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warnings don't give much benefits for developers. Code completion UI tends to show them unusable. But usually, developers can modify the context to accept async calls, e.g. by wrapping it with
Task { }rdar://126737530