[6.0] Remove an old, horrible compatibility hack in the _Concurrency module #73663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concurrency module was getting an implicit `-disable-availability-checking` as a workaround from the Swift 5.6 days. Remove it, because it causes problems with the new `Failure` type in the async for..in loop. Fixes a back-deployment issue with async algorithms in the _Concurrency library that use the async for..in loop.
|
@swift-ci please test |
hborla
approved these changes
May 16, 2024
ktoso
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Remove a Swift 5.6-era compatibility hack that disabled availability checking in the
_Concurrencymodule, which can lead to back-deployment issues with some algorithms and the newAsyncIteratorProtocol.Original PR: #73662
Radar/issue: rdar://127672617
Risk: Low. Makes the Swift interface for
_Concurrencybuild the same way the original module does.