Implement hasPrefix and hasSuffix in Swift #737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teach the non-Objective-C implementation how to calculate hasPrefix and hasSuffix on String data, by using the characters view to step through the comparison and current string at the same time. The performance of this will be capped at O(N) in the length of the compared String, provided that startIndex and endIndex are O(1). Note that the Objective-C implementation performs NFD normalisation, which is not done in this implementation. Bug: SR-337
|
Please feel free to submit another PR with a Unicode-correct one. |
kateinoigakukun
pushed a commit
to kateinoigakukun/swift
that referenced
this pull request
Sep 7, 2020
[pull] swiftwasm-release/5.3 from release/5.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach the non-Objective-C implementation how to calculate hasPrefix
and hasSuffix on String data, by using the characters view to step
through the comparison and current string at the same time. The
performance of this will be capped at O(N) in the length of the
compared String, provided that startIndex and endIndex are O(1).
Note that the Objective-C implementation performs NFD normalisation,
which is not done in this implementation.
Bug: SR-337