Skip to content

[6.0] stdlib: Fix a borrowing switch condfail #73701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2024
Merged

[6.0] stdlib: Fix a borrowing switch condfail #73701

merged 2 commits into from
May 17, 2024

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented May 17, 2024 •
edited
Loading

  • Explanation: Fixes a condfail related to adoption of borrowing switches in inlinable code in the standard library. #if compiler checks are needed to ensure older compilers don't attempt to parse the guarded code.
  • Scope: The issue prevents the standard library swiftinterface from building with older compilers, breaking important developer workflows.
  • Issue/Radar: rdar://128249510
  • Original PR: stdlib: Fix a borrowing switch condfail #73700
  • Risk: Low
  • Testing: Built the standard library interface manually with an older compiler.
  • Reviewer: @jckarter

@tshortli tshortli requested a review from a team as a code owner May 17, 2024 06:40
@tshortli
Copy link
Contributor Author

@swift-ci please test

@tbkka tbkka requested a review from jckarter May 17, 2024 15:40
@tshortli tshortli merged commit a1f9a6b into swiftlang:release/6.0 May 17, 2024
5 checks passed
@tshortli tshortli deleted the borrowing-switch-condfail-6.0 branch May 17, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter jckarter approved these changes

@tbkka tbkka tbkka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tshortli @jckarter @tbkka