When setting a willSet/didSet param's type, also set the TypeLoc #7377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually need the TypeLoc for anything, but it was still getting type-checked, which means it doesn't get the benefit of inference from the initial value. In some cases the actual type of the ParamDecl seems to get reset to the TypeLoc's type as well. Just do the simple thing and set it directly ahead of time. Fixes a source compatibility issue with Swift 3.0. https://bugs.swift.org/browse/SR-3893
|
@swift-ci Please test |
|
LGTM. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Feb 10, 2017
…ftlang#7377) We don't actually need the TypeLoc for anything, but it was still getting type-checked, which means it doesn't get the benefit of inference from the initial value. In some cases the actual type of the ParamDecl seems to get reset to the TypeLoc's type as well. Just do the simple thing and set it directly ahead of time. Fixes a source compatibility issue with Swift 3.0. https://bugs.swift.org/browse/SR-3893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually need the TypeLoc for anything, but it was still getting type-checked, which means it doesn't get the benefit of inference from the initial value. In some cases the actual type of the ParamDecl seems to get reset to the TypeLoc's type as well. Just do the simple thing and set it directly ahead of time.
Fixes a source compatibility issue with Swift 3.0.
SR-3893