[6.0][Concurrency] Fix missing return in legacy isSameExecutor mode detection #73774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves rdar://128425368 resolves rdar://127400013
|
@swift-ci please test |
ktoso
changed the title
ktoso
added
🍒 release cherry pick
|
Will be replaced by #73813 when we pick it to 6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes a missing return inside the #if !SWIFT_CONCURRENCY_EMBEDDED region which caused the entire dyld sdk detection not to work in practice.
Scope/Impact: dyld detection of "compiled against old sdk" was rendered useless by this typo; which may cause old applications to start crashing without recompiling.
Risk: Low; fixes trivial missing return statement.
Testing: CI testing
Reviewed by: @mikeash
Original PR:
Radar: rdar://128425368 rdar://127400013