Skip to content

[6.0][Runtime] Add weak check to use of _dyld_find_pointer_hash_table_entry. #73787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented May 21, 2024

Needed to avoid availability errors in some configurations.

rdar://127621414

…_entry.

Needed to avoid availability errors in some configurations.

rdar://127621414
(cherry picked from commit ae71658)
@mikeash mikeash requested a review from a team as a code owner May 21, 2024 15:01
@mikeash
Copy link
Contributor Author

mikeash commented May 21, 2024

@swift-ci please test

@mikeash
Copy link
Contributor Author

mikeash commented May 22, 2024

Explanation: Add a weak-link check to the conditionally available _dyld_find_pointer_hash_table_entry call.
Original PR: #73786
Reviewed by: @al45tair
Risk: Low. Just adds a NULL check and silences errors about not checking availability.
Resolves: rdar://127621414
Tests: This code is exercised by just about anything that runs.

@mikeash mikeash enabled auto-merge May 22, 2024 15:19
@mikeash mikeash merged commit e6e5b49 into swiftlang:release/6.0 May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants