IRGen: Properly adjust the closure type of a partial_apply of an objc_method #73791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Hacks on top of hacks on top of hacks ... |
…_method It needs to match with the (large loadable) lowered closure type in the rest of the program: Large types in the signature need to be passed indirectly. rdar://127367321
aschwaighofer
force-pushed
the
irgen_loadable_by_address_objc_method_closures
branch
from
b99b6d8 to
d89bf28
Compare
|
@swift-ci test |
aschwaighofer
added a commit
to aschwaighofer/swift
that referenced
this pull request
May 23, 2024
…n objc_method It needs to match with the (large loadable) lowered closure type in the rest of the program: Large types in the signature need to be passed indirectly. A failure to do so results in mis-matched ptr auth descriminators and a crash at runtime on arm64e. Scope: Should only affect programs that form closures of objective c methods involving large types Risk: Low for other code, medium for programs involving such closures Testing: A regression test was added rdar://127367321 Original PR: swiftlang#73791 (cherry picked from commit 69b635a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs to match with the (large loadable) lowered closure type in the rest of the program: Large types in the signature need to be passed indirectly.
rdar://127367321