Skip to content

Diverse stack unittest #7380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 10, 2017
Merged

Diverse stack unittest #7380

merged 7 commits into from
Feb 10, 2017

Conversation

gottesmm
Copy link
Contributor

This PR contains two small commits:

  1. 6d1058c: This just quiets some verbose logging from BlotMapVectorTest. You can still get the output by setting the llvm debug type to swift-blot-map-vector-test.
  2. 3c58e42: This commit adds two small unittests to DiverseStack. The first just makes sure that push/pop work and the second self documents that the DiverseStack is not a vector stack so if someone attempts to change this behavior, every place that uses DiverseStack in the compiler will need to be updated. = /.

@gottesmm
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 95cd4db into swiftlang:master Feb 10, 2017
@gottesmm gottesmm deleted the diverse_stack_unittest branch February 10, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gottesmm @swift-ci