[Caching] Don't rely on FileSystem when replaying diagnostics #73822
+148
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux platform |
|
ping |
benlangmuir
reviewed
May 31, 2024
| if (Input.getFileName() != "-") | ||
| SrcMgr.getExternalSourceBufferID(remapFilePath(Input.getFileName())); | ||
| auto Path = remapFilePath(Input.getFileName()); | ||
| SrcMgr.getExternalSourceBufferID(Path); |
There was a problem hiding this comment.
Duplicated with next line
There was a problem hiding this comment.
Those are two different SourceMgr. The first one is the one used to replay, and the second one is the actual SourceMgr from the instance.
There was a problem hiding this comment.
This deserves a comment or else rename SM so it's clear the difference
cachemeifyoucan
force-pushed
the
eng/PR-128423393
branch
from
1335162 to
0ccb256
Compare
|
@swift-ci please smoke test |
benlangmuir
reviewed
May 31, 2024
| if (Input.getFileName() != "-") | ||
| SrcMgr.getExternalSourceBufferID(remapFilePath(Input.getFileName())); | ||
| auto Path = remapFilePath(Input.getFileName()); | ||
| SrcMgr.getExternalSourceBufferID(Path); |
There was a problem hiding this comment.
This deserves a comment or else rename SM so it's clear the difference
benlangmuir
approved these changes
May 31, 2024
Stop relying on file system to provide source buffer for diagnostics when replying. This avoids initializing CASFS which is quite expensive. Now cached diagnostics contains CASID for the file buffer so it can initialize its own source manager without relying on the underlying file system. rdar://128423393
cachemeifyoucan
force-pushed
the
eng/PR-128423393
branch
from
0ccb256 to
c132f74
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop relying on file system to provide source buffer for diagnostics when replying. This avoids initializing CASFS which is quite expensive. Now cached diagnostics contains CASID for the file buffer so it can initialize its own source manager without relying on the underlying file system.
rdar://128423393